On 09/28/2018 12:17 PM, Ravi Bangoria wrote: > Hi Thomas, > > On 09/28/2018 03:32 PM, Thomas-Mich Richter wrote: >> I can rework the patch to use the is_supported() member function. The >> down side is that the test does not show up in the list of executed tests >> anymore, >> unless some debug output is enabled: > > Which should be fine because s390 is doing that in all breakpoint related > tests. > But more important thing to suggest .is_supported field is, this patch has a > regression on x86: > > Before: > $ sudo ./perf test 22 > 22: Watchpoint : > 22.1: Read Only Watchpoint : Skip > 22.2: Write Only Watchpoint : Ok > 22.3: Read / Write Watchpoint : Ok > 22.4: Modify Watchpoint : Ok > > After: > $ git apply 1.patch > $ make > $ sudo ./perf test 22 > 22: Watchpoint : > 22.1: Read Only Watchpoint : Skip > 22.2: Write Only Watchpoint : Skip > 22.3: Read / Write Watchpoint : Skip > 22.4: Modify Watchpoint : Skip > > Intel hw does not support read only watchpoitns. If you use skip_if_fail=true, > all subsequent testcases are skipped as well. > > Thanks, > Ravi >
Ahhh .... thanks a lot for the hint, will post version 3. -- Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
