On Friday 05 October 2018 01:20:59 chenchacha wrote: > This patch add fat ioctl command FAT_IOCTL_GET_VOLUME_LABEL. > > We can get the volume label with this command: > > ioctl(fd, FAT_IOCTL_GET_VOLUME_LABEL, &volume_label);
Hi! What is purpose of having such functionality in kernel? Userspace can read it without any kernel support. (e.g. mlabel or fatlabel) > FAT volume label (volume name) is exactly same stored in boot sector and root > directory. And this patch read label only from the root directory. If label in > root directory is missing then disk would be treated as without label. Label > from boot sector would not be read. > > The volume label format reference from Pali Rohár testing results > (https://www.spinics.net/lists/kernel/msg2645732.html) in the previous mail. > > chenchacha (2): > Add FAT_IOCTL_GET_VOLUME_LABEL in fat_generic_ioctl() > Add a new function to get root directory with ATTR_VOLUME > > fs/fat/dir.c | 13 +++++++++++++ > fs/fat/fat.h | 2 ++ > fs/fat/file.c | 22 ++++++++++++++++++++++ > include/uapi/linux/msdos_fs.h | 1 + > 4 files changed, 38 insertions(+) > -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: PGP signature
