Hi, On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd <[email protected]> wrote: > > + mas->irq = platform_get_irq(pdev, 0); > > + if (mas->irq < 0) { > > + ret = mas->irq; > > + dev_err(&pdev->dev, "Err getting IRQ %d\n", ret); > > + goto spi_geni_probe_runtime_disable; > > + } > > Nitpick: If you got the irq earlier before allocating anything then nothing > has > to be put on failure path.
I think this might have been in response to previous feedback from you suggesting that we should get the irq as late as possible. Ah, here ya go: https://lkml.kernel.org/r/153780767551.119890.9339380838620508...@swboyd.mtv.corp.google.com > Can you request this irq as late as possible in the probe function? I > worry there may be some pending irq line set and then this will cause an > interrupt storm with IRQ_NONE returned because the device is runtime > suspended. I'd rather handle the failure path then get the IRQ too early. -Doug
