Quoting Doug Anderson (2018-10-08 16:52:36) > Hi, > > On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd <[email protected]> wrote: > > > + mas->irq = platform_get_irq(pdev, 0); > > > + if (mas->irq < 0) { > > > + ret = mas->irq; > > > + dev_err(&pdev->dev, "Err getting IRQ %d\n", ret); > > > + goto spi_geni_probe_runtime_disable; > > > + } > > > > Nitpick: If you got the irq earlier before allocating anything then nothing > > has > > to be put on failure path. > > I think this might have been in response to previous feedback from you > suggesting that we should get the irq as late as possible. Ah, here > ya go: > > https://lkml.kernel.org/r/153780767551.119890.9339380838620508...@swboyd.mtv.corp.google.com
Yes I suggested we register for the irq as last as possible, but I didn't suggest calling platform_get_irq() this late. It could be called earlier so that if there isn't any irq then nothing to do besides return failure.
