On Wed 10-10-18 20:52:42, Michal Hocko wrote: [...] > My recollection was that we do clear the reserved bit in > move_pfn_range_to_zone and we indeed do in __init_single_page. But then > we set the bit back right afterwards. This seems to be the case since > d0dc12e86b319 which reorganized the code. I have to study this some more > obviously.
so my recollection was wrong and d0dc12e86b319 hasn't really changed much because __init_single_page wouldn't zero out the struct page for the hotplug contex. A comment in move_pfn_range_to_zone explains that we want the reserved bit because pfn walkers already do see the pfn range and the page is not fully associated with the zone until it is onlined. I am thinking that we might be overzealous here. With the full state initialized we shouldn't actually care. pfn_to_online_page should return NULL regardless of the reserved bit and normal pfn walkers shouldn't touch pages they do not recognize and a plain page with ref. count 1 doesn't tell much to anybody. So I _suspect_ that we can simply drop the reserved bit setting here. Regarding the post initialization required by devm_memremap_pages and potentially others. Can we update the altmap which is already a way how to get alternative struct pages by a constructor which we could call from memmap_init_zone and do the post initialization? This would reduce the additional loop in the caller while it would still fit the overall design of the altmap and the core hotplug doesn't have to know anything about DAX or whatever needs a special treatment. Does that make any sense? -- Michal Hocko SUSE Labs
