On Fri, 12 Oct 2018 11:21:28 -0700 Andy Lutomirski <[email protected]> wrote:
> On Fri, Oct 12, 2018 at 9:26 AM Steven Rostedt <[email protected]> wrote: > > > > > > Anyone have any issues with this patch? > > > > I'm conceptually okay with it. That being said, > regs_within_kernel_stack(), which you're indirectly using, is > off-by-a-few. And updating it to use probe_kernel_read() might be > nice for robustness. > 100% agree. I'll add a patch on top of it to make the changes, and keep what Masami had originally for full history. Thanks for taking the time to take a look at it. -- Steve
