Removes an unnecessary shadowed local variable (start).
    Optimize test of isdigit:
    - If isalpha returns true, isdigit will return false, so no need to test.

Signed-off-by: Leonardo Brás <[email protected]>
---
 scripts/asn1_compiler.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index c146020fc783..08bb6e5fd6ad 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)
 
                        /* Handle string tokens */
                        if (isalpha(*p)) {
-                               const char **dir, *start = p;
+                               const char **dir;
 
                                /* Can be a directive, type name or element
                                 * name.  Find the end of the name.
@@ -454,10 +454,9 @@ static void tokenise(char *buffer, char *end)
 
                                tokens[tix++].token_type = TOKEN_TYPE_NAME;
                                continue;
-                       }
+                       } else if (isdigit(*p)) {
+                               /* Handle numbers */
 
-                       /* Handle numbers */
-                       if (isdigit(*p)) {
                                /* Find the end of the number */
                                q = p + 1;
                                while (q < nl && (isdigit(*q)))
-- 
2.19.1

Reply via email to