> -----Original Message-----
> From: Jarkko Sakkinen [mailto:[email protected]]
> Sent: Thursday, October 18, 2018 03:15
> To: Winkler, Tomas <[email protected]>
> Cc: Jarkko Sakkinen <[email protected]>; Jason Gunthorpe
> <[email protected]>; Nayna Jain <[email protected]>; Usyskin,
> Alexander <[email protected]>; Struk, Tadeusz
> <[email protected]>; [email protected]; linux-security-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow.
> 
> On Tue, 16 Oct 2018, Tomas Winkler wrote:
> > First, rename out_no_locality to out_locality for bailing out on both
> > tpm_cmd_ready() and tpm_request_locality() failure.
> 
> This is unnecessary change and technically it is not a rename: the commit
> message text and the code change do not match. Rename is just a rename
> (i.e. change a variable name foo to bar).

I'm renaming the label because it doesn't match the code flow anymore,
I can change the commit message, but you please review the code.
Tomas




Reply via email to