On Mon, 22 Oct 2018 11:46:55 +0000 Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> wrote:
> Hi, > > > -----Original Message----- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Monday, October 22, 2018 5:13 PM > > To: Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> > > Cc: cristian.bir...@microchip.com; Tudor Ambarus > > <tudor.amba...@microchip.com>; rich...@nod.at; Mark Brown > > <broo...@kernel.org>; linux-kernel@vger.kernel.org; > > nicolas.fe...@microchip.com; marek.va...@gmail.com; > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille > > Pitchen > > <cyrille.pitc...@wedev4u.fr>; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 11:03:09 +0000 > > Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com> wrote: > > > > > Hi, > > > > > > > -----Original Message----- > > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > > Sent: Monday, October 22, 2018 4:23 PM > > > > To: Yogesh Narayan Gaur <yogeshnarayan.g...@nxp.com>; > > > > cristian.bir...@microchip.com > > > > Cc: Tudor Ambarus <tudor.amba...@microchip.com>; rich...@nod.at; > > > > Mark Brown <broo...@kernel.org>; linux-kernel@vger.kernel.org; > > > > nicolas.fe...@microchip.com; marek.va...@gmail.com; > > > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > > Cyrille Pitchen <cyrille.pitc...@wedev4u.fr>; > > > > computersforpe...@gmail.com; dw...@infradead.org; > > > > linux-arm-ker...@lists.infradead.org > > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform > > > > SFDP SPI NOR flash memories > > > > > > > > On Mon, 22 Oct 2018 12:46:27 +0200 > > > > Boris Brezillon <boris.brezil...@bootlin.com> wrote: > > > > > > > > > On Mon, 22 Oct 2018 10:39:48 +0000 Yogesh Narayan Gaur > > > > > <yogeshnarayan.g...@nxp.com> wrote: > > > > > > Patch used > > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2863,26 +2863,39 @@ static u8 spi_nor_smpt_read_dummy(const struct > spi_nor *nor, const u32 settings) > /* Determine if there are any optional Detection Command Descriptors > */ > - while (!(smpt[i] & SMPT_DESC_TYPE_MAP)) { > + for (i = 0; i< smpt_len; i++) { See, you should have i += 2 here, not i++. > + if ((smpt[i] & SMPT_DESC_TYPE_MAP)) > + break; > + > read_data_mask = SMPT_CMD_READ_DATA(smpt[i]); > nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]); > - nor->read_dummy = spi_nor_smpt_read_dummy(nor, smpt[i]); > + if (!nor->addr_width) > + nor->addr_width = 3; > + > + nor->read_dummy = 8; //spi_nor_smpt_read_dummy(nor, smpt[i]); > nor->read_opcode = SMPT_CMD_OPCODE(smpt[i]); > + pr_info("smpt[%d]=[addr_width:%08x, read_dumy:%08x, > read_opcode:%08x]\n", i, nor->addr_width, nor->read_dummy, nor->read_opcode); > + > addr = smpt[i + 1]; > > err = spi_nor_read_raw(nor, addr, 1, &data_byte); And add a trace here to print data_byte and addr. Thanks, Boris
