From: [email protected] <[email protected]> Sent: Wednesday, October 17, 2018 10:10 PM > From: Dexuan Cui <[email protected]> > > In kvp_send_key(), we do need call process_ib_ipinfo() if > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out > the userland hv_kvp_daemon needs the info of operation, adapter_id and > addr_family. With the incorrect fc62c3b1977d, the host can't get the > VM's IP via KVP. > > And, fc62c3b1977d added a "break;", but actually forgot to initialize > the key_size/value in the case of KVP_OP_SET, so the default key_size of > 0 is passed to the kvp daemon, and the pool files > /var/lib/hyperv/.kvp_pool_* can't be updated. > > This patch effectively rolls back the previous fc62c3b1977d, and > correctly fixes the "this statement may fall through" warnings. > > This patch is tested on WS 2012 R2 and 2016. > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall > through" warnings") > Signed-off-by: Dexuan Cui <[email protected]> > Cc: K. Y. Srinivasan <[email protected]> > Cc: Haiyang Zhang <[email protected]> > Cc: Stephen Hemminger <[email protected]> > Cc: <[email protected]> > Signed-off-by: K. Y. Srinivasan <[email protected]> > --- > drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > Reviewed-by: Michael Kelley <[email protected]>
