-----Original Message-----
From: Rob Herring [mailto:r...@kernel.org]
Sent: 2018年10月25日 7:57
To: Joakim Zhang <qiangqing.zh...@nxp.com>
Cc: linux-...@vger.kernel.org; w...@grandegger.com; m...@pengutronix.de;
mark.rutl...@arm.com; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org;
dl-linux-imx <linux-...@nxp.com>; A.s. Dong <aisheng.d...@nxp.com>
Subject: Re: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property
to device tree
On Tue, Oct 23, 2018 at 05:17:10AM +0000, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.d...@nxp.com>
>
> The FlexCAN controller can parse the stop-mode property to enable CAN
> self wakeup feature.
>
> Signed-off-by: Dong Aisheng <aisheng.d...@nxp.com>
> Signed-off-by: Joakim Zhang <qiangqing.zh...@nxp.com>
> ---
> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 8
> ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index bfc0c433654f..b5ccfc9c14fb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -24,6 +24,14 @@ Optional properties:
> if this property is present then controller is assumed to be
> big
> endian.
>
> +- stop-mode: register bits of stop mode control, the format is
Should have a vendor prefix: fsl,stop-mode
Okay, I will add it. Thanks a lot!
Best Regards,
Joakim Zhang
> + <&gpr req_gpr req_bit ack_gpr ack_bit>.
> + gpr is the phandle to general purpose register node.
> + req_gpr is the gpr register offset of CAN stop request.
> + req_bit is the bit offset of CAN stop request.
> + ack_gpr is the gpr register offset of CAN stop
> acknowledge.
> + ack_bit is the bit offset of CAN stop acknowledge.
> +
> Example:
>
> can@1c000 {
> --
> 2.17.1
>
