On Fri, Jul 06, 2007 at 12:21:52PM -0700, Christoph Lameter wrote:
> On Fri, 6 Jul 2007, Adrian Bunk wrote:
>
> > > Hmmm... This may be needed by the cpu idle code to update the vm stats
> > > before going idle.
> >
> > Since 1 year it's making the kernel image larger without having a single
> > user.
> >
> > And if it will one day get a user, removing the #if 0 will be trivial.
>
> Then just remove the whole function. the #if 0 is ugly.
Updated patch below.
cu
Adrian
<-- snip -->
This patch contains the following cleanups:
- make the needlessly global setup_vmstat() static
- remove the unused refresh_vm_stats()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
mm/vmstat.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
--- linux-2.6.22-rc6-mm1/mm/vmstat.c.old 2007-07-05 16:54:39.000000000
+0200
+++ linux-2.6.22-rc6-mm1/mm/vmstat.c 2007-07-08 22:27:26.000000000 +0200
@@ -353,23 +353,6 @@
}
}
-static void __refresh_cpu_vm_stats(void *dummy)
-{
- refresh_cpu_vm_stats(smp_processor_id());
-}
-
-/*
- * Consolidate all counters.
- *
- * Note that the result is less inaccurate but still inaccurate
- * if concurrent processes are allowed to run.
- */
-void refresh_vm_stats(void)
-{
- on_each_cpu(__refresh_cpu_vm_stats, NULL, 0, 1);
-}
-EXPORT_SYMBOL(refresh_vm_stats);
-
#endif
#ifdef CONFIG_NUMA
@@ -957,7 +940,7 @@
static struct notifier_block __cpuinitdata vmstat_notifier =
{ &vmstat_cpuup_callback, NULL, 0 };
-int __init setup_vmstat(void)
+static int __init setup_vmstat(void)
{
int cpu;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
