On Fri, 2018-11-02 at 00:30 +0800, Jianxin Pan wrote: > +struct meson_sclk_div_data mmc_clkc_div_data = { > + .div = { > + .reg_off = SD_EMMC_CLOCK, > + .shift = (0), > + .width = (6), > + }, > + .hi = { > + .reg_off = 0, > + .shift = 0, > + .width = 0, > + }, > +};
Jianxin, When replying to v5: https://patchwork.kernel.org/patch/10646723/#22288117 I think I have clearly explained that: a. sclk needs some change you want to use it for the eMMC (not done ) b. you can't declare sclk statically like that since there is cached data in it and this would forbib multiple instance of the controller which is not acceptable for this pariticular controller This is just not adressed in your series. Also some comments from Martin about useless definition were already given on past version. Seeing this, I did not review the rest of series. Please make sure you have addressed all the comments of past reviews before reposting. It is OK to ask questions if things are unclear. Jerome