On Mon, Nov 5, 2018 at 9:01 AM, Laura Abbott <[email protected]> wrote: > On 11/5/18 6:32 AM, Yangtao Li wrote: >> >> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >> > > Acked-by: Laura Abbott <[email protected]> > > >> Signed-off-by: Yangtao Li <[email protected]> >> --- >> arch/arm/mm/ptdump_debugfs.c | 12 +----------- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c >> index be8d87be4b93..201cd467a739 100644 >> --- a/arch/arm/mm/ptdump_debugfs.c >> +++ b/arch/arm/mm/ptdump_debugfs.c >> @@ -12,17 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v) >> return 0; >> } >> -static int ptdump_open(struct inode *inode, struct file *file) >> -{ >> - return single_open(file, ptdump_show, inode->i_private); >> -} >> - >> -static const struct file_operations ptdump_fops = { >> - .open = ptdump_open, >> - .read = seq_read, >> - .llseek = seq_lseek, >> - .release = single_release, >> -}; >> +DEFINE_SHOW_ATTRIBUTE(ptdump);
Nice! Can you do the same for arch/x86/mm/debug_pagetables.c too? Reviewed-by: Kees Cook <[email protected]> -Kees >> int ptdump_debugfs_register(struct ptdump_info *info, const char >> *name) >> { >> > -- Kees Cook
