On Sat, Nov 3, 2018 at 12:42 AM Borislav Petkov <b...@alien8.de> wrote:
>
> On Fri, Nov 02, 2018 at 10:39:59AM -0700, Luck, Tony wrote:
> > On Fri, Nov 02, 2018 at 05:10:13PM +0100, Borislav Petkov wrote:
> > > On Fri, Nov 02, 2018 at 04:32:06PM +0100, Arnd Bergmann wrote:
> > > > We cannot currently select ACPI_ADXL without also enabling the top-level
> > I have to say that Arnd's fix is prettier. With it, we can go back
> > to
> >
> > select ACPI_ADXL
> >
> > instead of
> >
> > select ACPI_ADXL if ACPI
>
> Arnd's fix already has that last line in there:
>
> config EDAC_SKX
> tristate "Intel Skylake server Integrated MC"
> - depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> + depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG && ACPI
> depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't
> be y
> select DMI
> select ACPI_ADXL if ACPI
> ^^^^^^^^^^^^^^^^^^^^^^^^
>
> so I'm reading this as *additionally* needed, ontop of the ugly fix.
>
> But let's wait until he clarifies first.
No, it was unintentional, the 'if ACPI' can be dropped when we add
'depends on ACPI'.
Arnd
