Now there's no user of MF_COUNT_INCREASED, so we can safely remove
all calling points.

Signed-off-by: Naoya Horiguchi <n-horigu...@ah.jp.nec.com>
---
 include/linux/mm.h  |  7 +++----
 mm/memory-failure.c | 16 +++-------------
 2 files changed, 6 insertions(+), 17 deletions(-)

diff --git v4.19-mmotm-2018-10-30-16-08/include/linux/mm.h 
v4.19-mmotm-2018-10-30-16-08_patched/include/linux/mm.h
index 22623ba..f85b450 100644
--- v4.19-mmotm-2018-10-30-16-08/include/linux/mm.h
+++ v4.19-mmotm-2018-10-30-16-08_patched/include/linux/mm.h
@@ -2725,10 +2725,9 @@ void register_page_bootmem_memmap(unsigned long 
section_nr, struct page *map,
                                  unsigned long nr_pages);
 
 enum mf_flags {
-       MF_COUNT_INCREASED = 1 << 0,
-       MF_ACTION_REQUIRED = 1 << 1,
-       MF_MUST_KILL = 1 << 2,
-       MF_SOFT_OFFLINE = 1 << 3,
+       MF_ACTION_REQUIRED = 1 << 0,
+       MF_MUST_KILL = 1 << 1,
+       MF_SOFT_OFFLINE = 1 << 2,
 };
 extern int memory_failure(unsigned long pfn, int flags);
 extern void memory_failure_queue(unsigned long pfn, int flags);
diff --git v4.19-mmotm-2018-10-30-16-08/mm/memory-failure.c 
v4.19-mmotm-2018-10-30-16-08_patched/mm/memory-failure.c
index 11e283e..ed347f8 100644
--- v4.19-mmotm-2018-10-30-16-08/mm/memory-failure.c
+++ v4.19-mmotm-2018-10-30-16-08_patched/mm/memory-failure.c
@@ -1094,7 +1094,7 @@ static int memory_failure_hugetlb(unsigned long pfn, int 
flags)
 
        num_poisoned_pages_inc();
 
-       if (!(flags & MF_COUNT_INCREASED) && !get_hwpoison_page(p)) {
+       if (!get_hwpoison_page(p)) {
                /*
                 * Check "filter hit" and "race with other subpage."
                 */
@@ -1290,7 +1290,7 @@ int memory_failure(unsigned long pfn, int flags)
         * In fact it's dangerous to directly bump up page count from 0,
         * that may make page_ref_freeze()/page_ref_unfreeze() mismatch.
         */
-       if (!(flags & MF_COUNT_INCREASED) && !get_hwpoison_page(p)) {
+       if (!get_hwpoison_page(p)) {
                if (is_free_buddy_page(p)) {
                        action_result(pfn, MF_MSG_BUDDY, MF_DELAYED);
                        return 0;
@@ -1331,10 +1331,7 @@ int memory_failure(unsigned long pfn, int flags)
        shake_page(p, 0);
        /* shake_page could have turned it free. */
        if (!PageLRU(p) && is_free_buddy_page(p)) {
-               if (flags & MF_COUNT_INCREASED)
-                       action_result(pfn, MF_MSG_BUDDY, MF_DELAYED);
-               else
-                       action_result(pfn, MF_MSG_BUDDY_2ND, MF_DELAYED);
+               action_result(pfn, MF_MSG_BUDDY_2ND, MF_DELAYED);
                return 0;
        }
 
@@ -1622,9 +1619,6 @@ static int __get_any_page(struct page *p, unsigned long 
pfn, int flags)
 {
        int ret;
 
-       if (flags & MF_COUNT_INCREASED)
-               return 1;
-
        /*
         * When the target page is a free hugepage, just remove it
         * from free hugepage list.
@@ -1906,15 +1900,11 @@ int soft_offline_page(struct page *page, int flags)
        if (is_zone_device_page(page)) {
                pr_debug_ratelimited("soft_offline: %#lx page is device page\n",
                                pfn);
-               if (flags & MF_COUNT_INCREASED)
-                       put_page(page);
                return -EIO;
        }
 
        if (PageHWPoison(page)) {
                pr_info("soft offline: %#lx page already poisoned\n", pfn);
-               if (flags & MF_COUNT_INCREASED)
-                       put_hwpoison_page(page);
                return -EBUSY;
        }
 
-- 
2.7.0

Reply via email to