On 11/09/2018 12:17 PM, Naoya Horiguchi wrote: > set_hwpoison_free_buddy_page() could fail, then the target page is > finally not isolated, so it's better to report -EBUSY for userspace > to know the failure and chance of retry. > IIUC set_hwpoison_free_buddy_page() could only fail if the page is not free in the buddy. At least for soft_offline_huge_page() that wont be the case otherwise dissolve_free_huge_page() would have returned non zero -EBUSY. Is there any other reason set_hwpoison_free_buddy_page() would not succeed ? > And for consistency, this patch moves set_hwpoison_free_buddy_page() > in unmap_and_move() to __soft_offline_page(). Yeah this check should be handled in soft offline functions not inside migrations they trigger.
- [PATCH RFC v1 00/11] hwpoison improvement part 1 Naoya Horiguchi
- [RFC][PATCH v1 08/11] mm: soft-offline: isolate err... Naoya Horiguchi
- [RFC][PATCH v1 07/11] mm: remove flag argument from... Naoya Horiguchi
- [RFC][PATCH v1 10/11] mm: clear PageHWPoison in mem... Naoya Horiguchi
- [RFC][PATCH v1 06/11] mm: hwpoison: remove MF_COUNT... Naoya Horiguchi
- [RFC][PATCH v1 02/11] mm: soft-offline: add missing... Naoya Horiguchi
- Re: [RFC][PATCH v1 02/11] mm: soft-offline: add... Anshuman Khandual
- [RFC][PATCH v1 04/11] mm: madvise: call soft_offlin... Naoya Horiguchi
- Re: [RFC][PATCH v1 04/11] mm: madvise: call sof... Anshuman Khandual
- [RFC][PATCH v1 11/11] mm: hwpoison: introduce clear... Naoya Horiguchi
- Re: [RFC][PATCH v1 11/11] mm: hwpoison: introdu... Anshuman Khandual
- [RFC][PATCH v1 05/11] mm: hwpoison-inject: don't pi... Naoya Horiguchi
- [RFC][PATCH v1 01/11] mm: hwpoison: cleanup unused ... Naoya Horiguchi
- Re: [RFC][PATCH v1 01/11] mm: hwpoison: cleanup... Anshuman Khandual
- [RFC][PATCH v1 09/11] mm: hwpoison: apply buddy pag... Naoya Horiguchi
- [RFC][PATCH v1 03/11] mm: move definition of num_po... Naoya Horiguchi
- Re: [RFC][PATCH v1 03/11] mm: move definition o... Anshuman Khandual