Hi Miquel, > -----Original Message----- > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > Sent: Friday, November 9, 2018 6:24 PM > To: Naga Sureshkumar Relli <nagas...@xilinx.com> > Cc: Boris Brezillon <boris.brezil...@bootlin.com>; rich...@nod.at; > dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; Michal Simek > <mich...@xilinx.com>; linux-...@lists.infradead.org; > linux-kernel@vger.kernel.org; > nagasures...@gmail.com; r...@kernel.org > Subject: Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree > binding > documentation > > Hi Naga, > > [...] > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > > > b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > > > new file mode 100644 > > > > index 0000000..b522daf > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > > > @@ -0,0 +1,32 @@ > > > > +Arasan NAND Flash Controller with ONFI 3.1 support > > > > + > > > > +Required properties: > > > > +- compatible: Should be "xlnx,zynqmp-nand", "arasan,nfc-v3p10" > > > > +- reg: Memory map for module access > > > > +- interrupts: Should contain the interrupt for the device > > > > +- clock-name: List of input clocks - "sys", "flash" > > > > + (See clock bindings for details) > > > > +- clocks: Clock phandles (see clock bindings for details) > > > > + > > > > +Required properties for child node: > > > > +- nand-ecc-mode: see nand.txt > > > > > > Why is it required? Can't you fallback to HW when this prop is missing? > > Yes, we can. > > Do you want me to update that in driver now? > > Looks like you have some comments in driver as well, so while > > addressing those I will update the code to fallback to HW ECC when It is > > missing. > > Yes, please. > > > > > > Oh, and reg is not listed in the required props. > > Which reg? > > I already mention this " reg: Memory map for module access " in > > required properties. > > > > Thanks, > > Naga Sureshkumar Relli > > > > > > > + > > > > +For NAND partition information please refer the below file > > > > +Documentation/devicetree/bindings/mtd/partition.txt > > > > + > > > > +Example: > > > > + nfc: nand@ff100000 { > > > > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"; > > > > + reg = <0x0 0xff100000 0x1000>; > > > > + clock-name = "sys", "flash"; > > > > + clocks = <&misc_clk &misc_clk>; > > > > + interrupt-parent = <&gic>; > > > > + interrupts = <0 14 4>; > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + nand@0 { > > > > + reg = <0>; > > This one, for the CS line(s). Ok got it. I will update.
Thanks, Naga Sureshkumar Relli > > > > > + nand-ecc-mode = "hw"; > > > > + }; > > > > + }; > > > > > Thanks, > Miquèl
