On Tue, Nov 20, 2018 at 11:04:21AM +0900, Namhyung Kim wrote: > On Mon, Nov 19, 2018 at 01:20:09PM +0100, Jiri Olsa wrote: > > We can't display the UI box saying that we are slow in reader > > thread. That will make perf top even slower and user even more > > angry ;-) > > > > Moving the UI box message out of the reader thread into UI thread > > and changing it into helpline, so there's no 'press any key' > > necessary. > > > > Link: http://lkml.kernel.org/n/tip-0rpmmt3omlait889ewp1c...@git.kernel.org > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > --- > > tools/perf/builtin-top.c | 16 +++++----------- > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > > index 047e99de09f3..1d77aa7650da 100644 > > --- a/tools/perf/builtin-top.c > > +++ b/tools/perf/builtin-top.c > > @@ -553,8 +553,6 @@ static void perf_top__sort_new_samples(void *arg) > > struct perf_evsel *evsel = t->sym_evsel; > > struct hists *hists; > > > > - perf_top__reset_sample_counters(t); > > - > > if (t->evlist->selected != NULL) > > t->sym_evsel = t->evlist->selected; > > > > @@ -571,6 +569,11 @@ static void perf_top__sort_new_samples(void *arg) > > > > hists__collapse_resort(hists, NULL); > > perf_evsel__output_resort(evsel, NULL); > > + > > + if (t->lost) > > + ui_helpline__fpush("Too slow to read ring buffer (change period > > (-c/-F) or limit CPUs (-C)\n"); > > In general, ui_helpline__[f]push() requires corresponding __pop() > which handles timeout logic (or something can dismiss the message). > The ui_helpline__show() is to show the message and overwrite the old > one. > > But we don't use it strictly and I think just pr_err() or pr_warning() > is ok here (which call ui_helpline__show() internally).
right, v2 attached there were some small conflicts in follow up patches, I pushed new version with resolved conflicts in perf/fixes branch thanks, jirka --- We can't display the UI box saying that we are slow in reader thread. That will make perf top even slower and user even more angry ;-) Moving the UI box message out of the reader thread into UI thread and changing it into helpline, so there's no 'press any key' necessary. Link: http://lkml.kernel.org/n/tip-0rpmmt3omlait889ewp1c...@git.kernel.org Signed-off-by: Jiri Olsa <jo...@kernel.org> --- tools/perf/builtin-top.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 047e99de09f3..d4105ba8510c 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -553,8 +553,6 @@ static void perf_top__sort_new_samples(void *arg) struct perf_evsel *evsel = t->sym_evsel; struct hists *hists; - perf_top__reset_sample_counters(t); - if (t->evlist->selected != NULL) t->sym_evsel = t->evlist->selected; @@ -571,6 +569,11 @@ static void perf_top__sort_new_samples(void *arg) hists__collapse_resort(hists, NULL); perf_evsel__output_resort(evsel, NULL); + + if (t->lost) + pr_warning("Too slow to read ring buffer (change period (-c/-F) or limit CPUs (-C)\n"); + + perf_top__reset_sample_counters(t); } static void *display_thread_tui(void *arg) @@ -908,10 +911,8 @@ static void perf_top__mmap_read(struct perf_top *top) { bool overwrite = top->record_opts.overwrite; struct perf_evlist *evlist = top->evlist; - unsigned long long start, end; int i; - start = rdclock(); if (overwrite) perf_evlist__toggle_bkw_mmap(evlist, BKW_MMAP_DATA_PENDING); @@ -922,13 +923,6 @@ static void perf_top__mmap_read(struct perf_top *top) perf_evlist__toggle_bkw_mmap(evlist, BKW_MMAP_EMPTY); perf_evlist__toggle_bkw_mmap(evlist, BKW_MMAP_RUNNING); } - end = rdclock(); - - if ((end - start) > (unsigned long long)top->delay_secs * NSEC_PER_SEC) - ui__warning("Too slow to read ring buffer.\n" - "Please try increasing the period (-c) or\n" - "decreasing the freq (-F) or\n" - "limiting the number of CPUs (-C)\n"); } /* -- 2.17.2
