On 11/28/2018 09:57 AM, Boris Brezillon wrote: > On Tue, 20 Nov 2018 11:55:21 +0000 > <tudor.amba...@microchip.com> wrote: > >> + >> + /* >> + * We set nor->addr_width here to skip spi_nor_set_4byte_opcodes() >> + * later because this latest function implements a legacy quirk for >> + * the erase size of Spansion memory. However this quirk is no longer >> + * needed with new SFDP compliant memories. >> + */ >> + nor->addr_width = 4; >> + nor->flags |= SPI_NOR_4B_OPCODES; > > You mean SNOR_F_4B_OPCODES (the one introduced here [1]), because > SPI_NOR_4B_OPCODES should only be used for flash_info->flags and might > soon conflict with another SNOR_F_ flag? >
yes, you're right. > [1]http://patchwork.ozlabs.org/patch/991476/ > Can you apply your patch? Will submit a new version afterwards. Thanks, ta
