On Tue, 4 Dec 2018 at 20:21, Steven Rostedt <[email protected]> wrote: > > On Tue, 4 Dec 2018 14:19:08 -0500 > Steven Rostedt <[email protected]> wrote: > > > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable) > > > /* Stop processing */ > > > return; > > > } > > > + /* > > > + * Some archs calls this function with interrupts or > > > preemption > > > + * disabled. Howeve, other archs don't and this can cause a > > typo "However". But could you write it this way: > > "However, for other archs that can preempt, this can cause an > tremendous unneeded latency." >
I'll fix this and move it up (where I added it in the first place but moved it) =) Cheers, Anders > Thanks! > > -- Steve > > > > + * tremendous unneeded latency. > > > + */ > > > > Actually, could you move the comment up where schedulable gets set? > > > > Thanks! > > > > -- Steve > > > > > + if (schedulable) > > > + cond_resched(); > > > } while_for_each_ftrace_rec(); > > > } > > > > > >
