On 19 Jul 2007 15:56:51 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > Juergen Beisert <[EMAIL PROTECTED]> writes: > > > Hi Andi, > > > > On Thursday 19 July 2007 11:25, Andi Kleen wrote: > > > On Thursday 19 July 2007 10:52:48 Juergen Beisert wrote: > > > > On Thursday 19 July 2007 10:22, Andi Kleen wrote: > > > > > > Wow, that's a really cool bug; nice work! Don't forget to update > > > > > > arch/i386/kernel/cpu/mtrr/state.c, though; it uses setCx86() as > > > > > > well. > > > > > > It needs to include processor-cyrix.h. > > > > > > > > > > It also needs some big fat comments > > > > > > > > No problem. Where to add? > > > > > > Where the inlines are defined. > > > > > > Also can you please resubmit full patches with full description > > > and Signed off lines, not incrementals? Thanks. > > > > Find attached. Hope its ok now. > > For future reference: > - Please send the patches inline if possible
+1! > - Generate them from top level (so path start with linux...) +2! > > I fixed it all up I have a sad little patch from Nick here which adds a new include/asm-x86_64/processor-cyrix.h. I guess this patch broke the x86_64 build. arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +- arch/i386/kernel/cpu/cyrix.c | 2 +- arch/i386/kernel/cpu/mtrr/cyrix.c | 1 + arch/i386/kernel/cpu/mtrr/state.c | 1 + include/asm-i386/processor-cyrix.h | 30 ++++++++++++++++++++++++++++++ include/asm-i386/processor.h | 11 ----------- include/asm-x86_64/processor.h | 11 ----------- Some of those .c files will be used by x86_64 too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
