Re: [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks

[Dave Hansen]

On 12/11/18 4:34 PM, Li, Aubrey wrote:
>> Is there a reason we shouldn't do:
>>
>>      if (!cpu_feature_enabled(X86_FEATURE_AVX512F))
>>              update_avx512_state(fpu);
>>
>> ?
>>
> Why _!_ ?

Sorry, got it backwards.  I think I was considering having you do a

        if (!cpu_feature_enabled(X86_FEATURE_AVX512F))
                return;

inside of update_avx512_state(), but I got the state mixed up in my head.

You don't need the '!'.