On 2018/12/14 7:42, Paul Moore wrote: > On Sun, Dec 9, 2018 at 1:25 AM YueHaibing <[email protected]> wrote: >> Remove duplicated include. >> >> Signed-off-by: YueHaibing <[email protected]> >> --- >> kernel/audit.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/kernel/audit.c b/kernel/audit.c >> index a0a4544..632d360 100644 >> --- a/kernel/audit.c >> +++ b/kernel/audit.c >> @@ -60,7 +60,6 @@ >> #include <linux/mutex.h> >> #include <linux/gfp.h> >> #include <linux/pid.h> >> -#include <linux/slab.h> > > As discussed previously, I don't want to remove header files whose > declarations are used in the source file. While it may be true that > slab.h is included in one of the previously included header files, I > like leaving it as an explicit include to help document the dependency > and protect us from changes in the other header files.
The slab.h is included twice in audit.c , It like this: #include <linux/file.h> #include <linux/init.h> #include <linux/types.h> #include <linux/atomic.h> #include <linux/mm.h> #include <linux/export.h> #include <linux/slab.h> //the first #include <linux/err.h> #include <linux/kthread.h> #include <linux/kernel.h> #include <linux/syscalls.h> #include <linux/spinlock.h> #include <linux/rcupdate.h> #include <linux/mutex.h> #include <linux/gfp.h> #include <linux/pid.h> #include <linux/slab.h> //duplicated > > -- > paul moore > www.paul-moore.com > >
