Commit-ID:  571766010ea6bf9726b288eb2db1abb59b1841af
Gitweb:     https://git.kernel.org/tip/571766010ea6bf9726b288eb2db1abb59b1841af
Author:     Adrian Hunter <adrian.hun...@intel.com>
AuthorDate: Tue, 27 Nov 2018 10:46:34 +0200
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Tue, 18 Dec 2018 12:21:44 -0300

perf auxtrace: Alter addr_filter__entire_dso() to work if there are no symbols

addr_filter__entire_dso() uses the first and last symbols from a dso,
and so does not work when there are no symbols.  Alter it to filter the
whole file instead.

Signed-off-by: Adrian Hunter <adrian.hun...@intel.com>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Masami Hiramatsu <mhira...@kernel.org>
Cc: Mathieu Poirier <mathieu.poir...@linaro.org>
Fixes: 1b36c03e3569 ("perf record: Add support for using symbols in address 
filters")
Link: http://lkml.kernel.org/r/20181127084634.12469-1-adrian.hun...@intel.com
[ split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/auxtrace.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 72d5ba2479bf..f69961c4a4f3 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1983,17 +1983,14 @@ static int find_dso_sym(struct dso *dso, const char 
*sym_name, u64 *start,
 
 static int addr_filter__entire_dso(struct addr_filter *filt, struct dso *dso)
 {
-       struct symbol *first_sym = dso__first_symbol(dso);
-       struct symbol *last_sym = dso__last_symbol(dso);
-
-       if (!first_sym || !last_sym) {
-               pr_err("Failed to determine filter for %s\nNo symbols found.\n",
+       if (dso__data_file_size(dso, NULL)) {
+               pr_err("Failed to determine filter for %s\nCannot determine 
file size.\n",
                       filt->filename);
                return -EINVAL;
        }
 
-       filt->addr = first_sym->start;
-       filt->size = last_sym->end - first_sym->start;
+       filt->addr = 0;
+       filt->size = dso->data.file_size;
 
        return 0;
 }

Reply via email to