Quoting Russell King - ARM Linux (2018-12-22 02:33:20) > On Fri, Dec 21, 2018 at 11:24:52PM -0800, Stephen Boyd wrote: > > A grep of the kernel shows that many drivers print an error message if > > they fail to get the irq they're looking for. Furthermore, those drivers > > all decide to print the device name, or not, and the irq they were > > requesting, or not, etc. Let's consolidate all these error messages into > > the API itself, allowing us to get rid of the error messages in each > > driver. > ... > > +error: > > + if (warn) > > + dev_err(&dev->dev, "IRQ%d not found\n", num); > > Please don't use the notation IRQn - this is normally used when > referring to interrupt numbers (such as those seen in > /proc/interrupts) rather than a per-device interrupt index. > Grep for IRQ% in drivers/ for many examples. > > dev_err(&dev->dev, "IRQ index %u not found: %d\n", num, ret);
Sure! I'll use that one. > > would be better - note also the use of %u for unsigned integers. > Using %d for them is IMHO sloppy coding. > Ok.
