+ Mark +linux-kernel On Sun, 30 Dec 2018 at 08:45, Andreas Färber <afaer...@suse.de> wrote: > > When converting to regmap_bus we omitted the write flag, > rendering all sx125x register writes no-op. > > Signed-off-by: Andreas Färber <afaer...@suse.de> > --- > drivers/net/lora/sx130x_radio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/lora/sx130x_radio.c b/drivers/net/lora/sx130x_radio.c > index 6c94d13cd4db..e7b2df808c1a 100644 > --- a/drivers/net/lora/sx130x_radio.c > +++ b/drivers/net/lora/sx130x_radio.c > @@ -9,6 +9,7 @@ > * Copyright (c) 2013 Semtech-Cycleo > */ > > +#include <linux/bitops.h> > #include <linux/of.h> > #include <linux/of_device.h> > #include <linux/regmap.h> > @@ -40,7 +41,7 @@ static int sx1301_regmap_bus_write(void *context, unsigned > int reg, > ret = regmap_write(priv->regmap, cs, 0); > if (ret) > return ret; > - ret = regmap_write(priv->regmap, addr, reg); > + ret = regmap_write(priv->regmap, addr, BIT(7) | reg);
Curious. Isn't the (read/write)_flag_mask, set in the regmap_config, a property of the device connected to the regmap_bus? I would have expected this to have been applied prior to passing to a regmap_bus call, surely the bus should only be concerned with transport? It will work in our case as our current hardware uses 1 in bit 7 but it will not if we ever see other radios with different masks. If the regmap_bus provider does need to apply the mask, can we get the end device regmap_config and apply it from there? Mark what are your thoughts on the route to take? Regards, Ben Whitten
