Re: [PATCH] RISC-V: fix bad use of of_node_put

[Atish Patra]

On 1/7/19 6:16 AM, Andreas Schwab wrote:

of_find_node_by_type already calls of_node_put, don't call it again.

Fixes: 94f9bf118f ("RISC-V: Fix of_node_* refcount")
Signed-off-by: Andreas Schwab <sch...@suse.de>
---
  arch/riscv/kernel/smpboot.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
index fc185ecabb..18cda0e8cf 100644
--- a/arch/riscv/kernel/smpboot.c
+++ b/arch/riscv/kernel/smpboot.c
@@ -57,15 +57,12 @@ void __init setup_smp(void)

while ((dn = of_find_node_by_type(dn, "cpu"))) {

                hart = riscv_of_processor_hartid(dn);
-               if (hart < 0) {
-                       of_node_put(dn);
+               if (hart < 0)
                        continue;
-               }

if (hart == cpuid_to_hartid_map(0)) {

                        BUG_ON(found_boot_cpu);
                        found_boot_cpu = 1;
-                       of_node_put(dn);
                        continue;
                }

@@ -73,7 +70,6 @@ void __init setup_smp(void)

                set_cpu_possible(cpuid, true);
                set_cpu_present(cpuid, true);
                cpuid++;
-               of_node_put(dn);
        }

BUG_ON(!found_boot_cpu);

Thanks for catching and fixing this.

Reviewed-by: Atish Patra <atish.pa...@wdc.com>

Regards,
Atish