On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote:
> Fix kernel NULL pointer dereference error when mbox_request_channel()
> fails to allocate channel.
>
> Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox
> channel")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokata...@broadcom.com>
> ---
> drivers/dma/bcm-sba-raid.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> index 72878ac5c78d..77ae74663a45 100644
> --- a/drivers/dma/bcm-sba-raid.c
> +++ b/drivers/dma/bcm-sba-raid.c
> @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev)
> sba->mchan = mbox_request_channel(&sba->client, 0);
> if (IS_ERR(sba->mchan)) {
> ret = PTR_ERR(sba->mchan);
> - goto fail_free_mchan;
> + goto fail_exit;
> }
>
> /* Find-out underlying mailbox device */
> @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev)
> sba_freeup_channel_resources(sba);
> fail_free_mchan:
> mbox_free_channel(sba->mchan);
> +fail_exit:
> return ret;
> }
>
>
Looks good to me.
Reviewed-by: Ray Jui <ray....@broadcom.com>
