On Thu, 2019-01-10 at 14:49 -0800, Vadim Bendebury wrote: > Presently C99 style comments are removed unconditionally before actual > patch validity check happens. This is a problem for some third party > projects which use checkpatch.pl but do not allow C99 style comments. > > This patch adds yet another variable, named C99_COMMENT_TOLERANCE. If > it is included in the --ignore command line or config file options > list, C99 comments in the patch are reported as errors. > > Tested by processing a patch with a C99 style comment, it passes the > check just fine unless '--ignore C99_COMMENT_TOLERANCE' is present in > .checkpatch.conf. > > Signed-off-by: Vadim Bendebury <vben...@chromium.org>
Seems sensible enough. > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index b737ca9d7204..8a1aaeb8fa1b 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -61,7 +61,7 @@ my $codespellfile = "/usr/share/codespell/dictionary.txt"; > my $conststructsfile = "$D/const_structs.checkpatch"; > my $typedefsfile = ""; > my $color = "auto"; > -my $allow_c99_comments = 1; > +my $allow_c99_comments = 1; # Can be overridden by --ignore > C99_COMMENT_TOLERANCE > > sub help { > my ($exitcode) = @_; > @@ -1011,6 +1011,7 @@ if ($git) { > } > > my $vname; > +$allow_c99_comments = !defined $ignore_type{"C99_COMMENT_TOLERANCE"}; > for my $filename (@ARGV) { > my $FILE; > if ($git) {