Hello Adrian, On Wed, 16 Jan 2019 14:59:32 +0200, Adrian Hunter wrote:
> > The below patch simply changes sdhci_check_ro() to use the value of > > the WP GPIO if available. We need to adjust the prototype of the > > function to use a mmc_host* as argument instead of sdhci_host*, since > > the mmc_can_gpio_ro() and mmc_gpio_get_ro() helpers take a mmc_host*. > > Why not just use host->mmc Could do that. I just found it weird that the calling function has the mmc_host structure, does some gymnastic to find sdhci_host, and then in the called function, we do the opposite gymnastic to find mmc_host from sdhci_host. But if that's the preference, I'm happy to change the patch accordingly. > > if (host->flags & SDHCI_DEVICE_DEAD) > > is_readonly = 0; > > + else if (mmc_can_gpio_ro(mmc)) > > + is_readonly = mmc_gpio_get_ro(mmc); > > Perhaps host->ops->get_ro should be checked before mmc_can_gpio_ro()? That is actually a good point, using ->get_ro() should come before using the GPIO. Indeed, some drivers may potentially have a ->get_ro with custom logic *and* a WP GPIO, and in this case, we want ->get_ro to take precedence. I'll send a v2 with this, once you let me know your decision about the previous point. Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
