On 1/16/19 3:06 PM, Florian Fainelli wrote: > On 1/16/19 2:29 PM, Andrew Lunn wrote: >>> diff --git a/include/net/dsa.h b/include/net/dsa.h >>> index b3eefe8e18fd..6178b648d08a 100644 >>> --- a/include/net/dsa.h >>> +++ b/include/net/dsa.h >>> @@ -21,6 +21,7 @@ >>> #include <linux/ethtool.h> >>> #include <linux/net_tstamp.h> >>> #include <linux/phy.h> >>> +#include <linux/platform_data/dsa.h> >>> #include <net/devlink.h> >>> #include <net/switchdev.h> >> >> Hi Florian >> >> Could there be one more patch at the end which removes this? I think >> it is here just as an intermediary step? > > Yes, we can have only dsa2.c and legacy.c include that file from there > on, I will resubmit with that change, thanks!
We actually need to keep that include in there, because we use DSA_MAX_SWITCHES in net/dsa.h and splitting that define away could be a bit tedious since it is used by dsa_platform_data which was exposed before. Another option could be to not expose dsa_platform_data all, only dsa_chip_data which describes a single switch, and then we can have a nice and lean platform_data/dsa.h file that only has a few definitions. Which route do you prefer? -- Florian