On Wed, Jan 16, 2019 at 7:17 AM Peter Oberparleiter <ober...@linux.ibm.com> wrote: > > On 15.01.2019 19:36, Tri Vo wrote: > > From: Tri Vo <tr...@android.com> > > > > This patch series adds Clang supoprt for gcov. > > > > Patch 1 refactors existing code in preparation for Clang support. Patches > > 2-3 implement necessary LLVM runtime hooks and gcov kernel interfaces. > > Patch 4 simplifies config selection. > > > > Greg Hackmann (2): > > gcov: clang: move common gcc code into gcc_base.c > > gcov: clang support > > > > Nick Desaulniers (1): > > gcov: clang: link/unlink profiling data set. > > > > Tri Vo (1): > > gcov: clang: pick GCC vs Clang format depending on compiler > > Overall this patch set looks good to me. It introduces a clean way for > GCC and Clang specific implementation details to coexist. > > A quick test compile using GCC on s390 with the patch set applied was > successful, so it seems like the existing support is unaffected. > > There are some detail suggestions on patch improvements that I'll post > in separate e-mails.
Peter, Thank you so much for the valuable code review and feedback. We'll prep a v3. Tri, I think you should change the authorship for the patches to yourself, and add a "Co-authored-by: " tag to the commit messages. Can probably squash this series into 2 patches; the one that separates out the shared code; and the new llvm additions. WDYT? -- Thanks, ~Nick Desaulniers
