On Mon, 2019-01-21 at 10:58 +0900, Chanwoo Choi wrote: > On 19. 1. 20. 오전 1:04, Yangtao Li wrote: > > To beautify the code format.
I believe half of the changes are actually _less_ beautiful. > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c [] > > @@ -683,16 +683,15 @@ struct devfreq *devfreq_add_device(struct device *dev, > > goto err_out; > > } > > > > - devfreq->trans_table = > > - devm_kzalloc(&devfreq->dev, > > - array3_size(sizeof(unsigned int), > > - devfreq->profile->max_state, > > - devfreq->profile->max_state), > > - GFP_KERNEL); > > + devfreq->trans_table = devm_kzalloc(&devfreq->dev, > > + array3_size(sizeof(unsigned int), > > + devfreq->profile->max_state, > > + devfreq->profile->max_state), > > + GFP_KERNEL); I think this bit is worse because the array3_size arguments are no longer aligned. > > devfreq->time_in_state = devm_kcalloc(&devfreq->dev, > > - devfreq->profile->max_state, > > - sizeof(unsigned long), > > - GFP_KERNEL); > > + devfreq->profile->max_state, > > + sizeof(unsigned long), > > + GFP_KERNEL); and this bit is better.
