On Tue, Jan 22, 2019 at 03:25:09AM +0800, Peng Hao wrote: > Add pvpanic acpi driver in pvpanic driver framework. > > Signed-off-by: Peng Hao <[email protected]> > --- > drivers/misc/pvpanic/Kconfig | 9 +++++ > drivers/misc/pvpanic/Makefile | 1 + > drivers/misc/pvpanic/pvpanic-acpi.c | 77 > +++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+) > create mode 100644 drivers/misc/pvpanic/pvpanic-acpi.c > > diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig > index 3e612c6..d274130 100644 > --- a/drivers/misc/pvpanic/Kconfig > +++ b/drivers/misc/pvpanic/Kconfig > @@ -5,3 +5,12 @@ config PVPANIC > This driver provides support for the pvpanic device. pvpanic is > a paravirtualized device provided by QEMU; it lets a virtual machine > (guest) communicate panic events to the host. > + > +if PVPANIC > + > +config PVPANIC_ACPI > + tristate "pvpanic acpi driver" > + depends on ACPI > + default PVPANIC
No help text at all? Not good. > + > +endif > diff --git a/drivers/misc/pvpanic/Makefile b/drivers/misc/pvpanic/Makefile > index 6394224..c5b73ca 100644 > --- a/drivers/misc/pvpanic/Makefile > +++ b/drivers/misc/pvpanic/Makefile > @@ -3,3 +3,4 @@ > # Copyright (c) 2018 ZTE Ltd. > > obj-$(CONFIG_PVPANIC) += pvpanic.o > +obj-$(CONFIG_PVPANIC_ACPI) += pvpanic-acpi.o Not aligned? > diff --git a/drivers/misc/pvpanic/pvpanic-acpi.c > b/drivers/misc/pvpanic/pvpanic-acpi.c > new file mode 100644 > index 0000000..a6153fa > --- /dev/null > +++ b/drivers/misc/pvpanic/pvpanic-acpi.c > @@ -0,0 +1,77 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later Are you sure? And also, shouldn't this be written as: // SPDX-License-Identifier: GPL-2.0+ thanks, greg k-h
