On Thu, 2019-01-17 at 14:38 -0800, Andrey Smirnov wrote: [...] > > To be honest, I don't like these two, I'm not convinced anymore that > > they actually qualify as reset signals. To me it looks like this is > > something that the PCIe glue code should handle via syscon like i.MX6. > > Leonard, Lucas, what do you think? > > OK, one thing to keep in mind about this is that those bits are > already exposed for i.MX7D and I think (correct me if I am wrong) > there's no going back there.
That's not a reason to repeat the same mistake for i.MX8QM, but at the moment I'm still trying to figure out if it actually was a mistake. > PCIe driver already has the code to use > those on i.MX7D and, due to high degree of similarity, i.MX8MQ > actually re-uses the same codepath (at least for > IMX8MQ_RESET_PCIE_CTRL_APPS_EN). We can always switch to i.MX6-like direct syscon/GPR manipulation and just drop the resets from DT. Since if this is done, it should be done for i.MX7 as well, I see no reason for this issue to hold up your i.MX8M changes. regards Philipp