Re: [PATCH v2 3/7] KVM:CPUID: Add CPUID support for CET xsaves component query.

[Paolo Bonzini]

On 22/01/19 21:59, Yang Weijiang wrote:
>                        */
>                       entry->edx |= F(ARCH_CAPABILITIES);
> +                     /*
> +                      * If host doesn't have CET capability,
> +                      * do not report CET related info.
> +                      */
> +                     if (!boot_cpu_has(X86_FEATURE_SHSTK))
> +                             entry->ecx &= ~F(SHSTK);
> +
> +                     if (!boot_cpu_has(X86_FEATURE_IBT))
> +                             entry->edx &= ~F(IBT);
> +

This is not needed, it is implied by

                        cpuid_mask(&entry->ecx, CPUID_7_ECX);
                        cpuid_mask(&entry->edx, CPUID_7_EDX);

earlier in the function.

Paolo