On Thu, 24 Jan 2019, Andy Shevchenko wrote: > We now using a common macro for PM operations in Intel LPSS driver, > and, since that macro relies on the definition and macro from linux/pm.h > header file, it's logical to include it directly in intel-lpss.h. > Otherwise it's a bit fragile and requires a proper ordering > of header inclusion in C files.
I don't agree with this. File which use various headers should explicitly include them. Inheriting header files is non-optimal. > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > drivers/mfd/intel-lpss-acpi.c | 1 - > drivers/mfd/intel-lpss-pci.c | 1 - > drivers/mfd/intel-lpss.h | 2 ++ > 3 files changed, 2 insertions(+), 2 deletions(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
