Hi Ronald, Thank you for the patch! Yet something to improve:
[auto build test ERROR on input/next] [also build test ERROR on v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/drm-bridge-sil_sii8620-depend-on-INPUT-instead-of-selecting-it/20190205-003319 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=sh All error/warnings (new ones prefixed by >>): drivers/input/keyboard/applespi.c: In function 'applespi_enable_spi': >> drivers/input/keyboard/applespi.c:692:11: error: implicit declaration of >> function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? >> [-Werror=implicit-function-declaration] result = acpi_evaluate_integer(applespi->sist, NULL, NULL, &spi_status); ^~~~~~~~~~~~~~~~~~~~~ acpi_evaluate_object >> drivers/input/keyboard/applespi.c:697:11: error: implicit declaration of >> function 'acpi_execute_simple_method'; did you mean 'acpi_install_method'? >> [-Werror=implicit-function-declaration] result = acpi_execute_simple_method(applespi->sien, NULL, 1); ^~~~~~~~~~~~~~~~~~~~~~~~~~ acpi_install_method At top level: drivers/input/keyboard/applespi.c:1851:12: warning: 'applespi_resume' defined but not used [-Wunused-function] static int applespi_resume(struct device *dev) ^~~~~~~~~~~~~~~ drivers/input/keyboard/applespi.c:1808:12: warning: 'applespi_suspend' defined but not used [-Wunused-function] static int applespi_suspend(struct device *dev) ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/spi/spi-pxa2xx-pci.c: In function 'pxa2xx_spi_pci_probe': >> drivers/spi/spi-pxa2xx-pci.c:205:8: error: implicit declaration of function >> 'pcim_enable_device'; did you mean 'pci_enable_device'? >> [-Werror=implicit-function-declaration] ret = pcim_enable_device(dev); ^~~~~~~~~~~~~~~~~~ pci_enable_device >> drivers/spi/spi-pxa2xx-pci.c:235:8: error: implicit declaration of function >> 'pci_alloc_irq_vectors'; did you mean 'pci_alloc_consistent'? >> [-Werror=implicit-function-declaration] ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES); ^~~~~~~~~~~~~~~~~~~~~ pci_alloc_consistent drivers/spi/spi-pxa2xx-pci.c:235:41: error: 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function); did you mean 'PCI_PRI_ALLOC_REQ'? ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES); ^~~~~~~~~~~~~~~~~ PCI_PRI_ALLOC_REQ drivers/spi/spi-pxa2xx-pci.c:235:41: note: each undeclared identifier is reported only once for each function it appears in >> drivers/spi/spi-pxa2xx-pci.c:238:13: error: implicit declaration of function >> 'pci_irq_vector'; did you mean 'rcu_irq_enter'? >> [-Werror=implicit-function-declaration] ssp->irq = pci_irq_vector(dev, 0); ^~~~~~~~~~~~~~ rcu_irq_enter drivers/spi/spi-pxa2xx-pci.c: At top level: >> drivers/spi/spi-pxa2xx-pci.c:296:1: warning: data definition has no type or >> storage class module_pci_driver(pxa2xx_spi_pci_driver); ^~~~~~~~~~~~~~~~~ >> drivers/spi/spi-pxa2xx-pci.c:296:1: error: type defaults to 'int' in >> declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/spi/spi-pxa2xx-pci.c:296:1: warning: parameter names (without types) >> in function declaration drivers/spi/spi-pxa2xx-pci.c:289:26: warning: 'pxa2xx_spi_pci_driver' defined but not used [-Wunused-variable] static struct pci_driver pxa2xx_spi_pci_driver = { ^~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +692 drivers/input/keyboard/applespi.c 685 686 static int applespi_enable_spi(struct applespi_data *applespi) 687 { 688 int result; 689 unsigned long long spi_status; 690 691 /* check if SPI is already enabled, so we can skip the delay below */ > 692 result = acpi_evaluate_integer(applespi->sist, NULL, NULL, > &spi_status); 693 if (ACPI_SUCCESS(result) && spi_status) 694 return 0; 695 696 /* SIEN(1) will enable SPI communication */ > 697 result = acpi_execute_simple_method(applespi->sien, NULL, 1); 698 if (ACPI_FAILURE(result)) { 699 pr_err("SIEN failed: %s\n", acpi_format_exception(result)); 700 return -ENODEV; 701 } 702 703 /* 704 * Allow the SPI interface to come up before returning. Without this 705 * delay, the SPI commands to enable multitouch mode may not reach 706 * the trackpad controller, causing pointer movement to break upon 707 * resume from sleep. 708 */ 709 msleep(50); 710 711 return 0; 712 } 713 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
