On Fri, Feb 08, 2019 at 04:42:39PM +0100, Borislav Petkov wrote: > On Fri, Feb 08, 2019 at 01:02:53AM -0500, Michael S. Tsirkin wrote: > > Use linux/mman.h to make sure we get all mmap flags we need. > > Why, asm/mman.h is not enough or is this fixing a build issue or what is that > patch supposed to address?
Coding style violation: if a linux/foo.h exists then it must be included in preference to asm/foo.h And the specific issue is that a follow-up patch moves code from asm/mman.h to linux/mman.h so if any one was indirectly using this header it will now miss the symbols that are being moved. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > --- > > arch/x86/mm/mpx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c > > index de1851d15699..c805db6236b4 100644 > > --- a/arch/x86/mm/mpx.c > > +++ b/arch/x86/mm/mpx.c > > @@ -9,12 +9,12 @@ > > #include <linux/kernel.h> > > #include <linux/slab.h> > > #include <linux/mm_types.h> > > +#include <linux/mman.h> > > #include <linux/syscalls.h> > > #include <linux/sched/sysctl.h> > > > > #include <asm/insn.h> > > #include <asm/insn-eval.h> > > -#include <asm/mman.h> > > #include <asm/mmu_context.h> > > #include <asm/mpx.h> > > #include <asm/processor.h> > > -- > > Thx. > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply.
