Hi Dan, Thank you for the patch,
On 15/02/2019 19:17, Dan Robertson wrote: > The linux constants MS_RDONLY, MS_SYNCHRONOUS, MS_MANDLOCK, MS_DIRSYNC, > MS_NOATIME, and MS_NODIRATIME were previously defined in linux/fs.h. > Following e262e32d6bde0f77fb0c95d977482fc872c51996 the constants are > now defined in uapi/linux/mount.h. The new location of the defined > constants needs to be included in constants.py template in order for the > correct constants to be generated. > This commit was pipped to the post by a similar patch [0] from Felipe Balbi [0] https://lore.kernel.org/lkml/[email protected]/ Combined together they would form a complete patch, but this one could do with the Fixes: tag such as Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled" With a Fixes: tag: Reviewed-by: Kieran Bingham <[email protected]> > Signed-off-by: Dan Robertson <[email protected]> > --- > scripts/gdb/linux/constants.py.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/gdb/linux/constants.py.in > b/scripts/gdb/linux/constants.py.in > index 7aad82406422..6c164761d986 100644 > --- a/scripts/gdb/linux/constants.py.in > +++ b/scripts/gdb/linux/constants.py.in > @@ -12,9 +12,9 @@ > * > */ > > -#include <linux/fs.h> Whereas Felipe's patch does not include this change (which I think it looks like it should) How should we proceed with these two competing patches? Any preference from anyone? Content wise, I feel like this one is in the lead - just missing the Fixes: tag, but Felipe's won the race... -- Kieran > #include <linux/mount.h> > #include <linux/of_fdt.h> > +#include <uapi/linux/mount.h> > > /* We need to stringify expanded macros so that they can be parsed */ > > @@ -36,7 +36,7 @@ > > import gdb > > -/* linux/fs.h */ > +/* uapi/linux/mount.h */ > LX_VALUE(MS_RDONLY) > LX_VALUE(MS_SYNCHRONOUS) > LX_VALUE(MS_MANDLOCK) > -- Regards -- Kieran
