> -----Original Message----- > From: Lorenzo Pieralisi [mailto:lorenzo.pieral...@arm.com] > Sent: 15 February 2019 11:40 > To: Shameerali Kolothum Thodi <shameerali.kolothum.th...@huawei.com> > Cc: robin.mur...@arm.com; andrew.mur...@arm.com; > jean-philippe.bruc...@arm.com; will.dea...@arm.com; > mark.rutl...@arm.com; Guohanjun (Hanjun Guo) <guohan...@huawei.com>; > John Garry <john.ga...@huawei.com>; pa...@codeaurora.org; > vkil...@codeaurora.org; rruig...@codeaurora.org; linux-a...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Linuxarm > <linux...@huawei.com>; neil.m.lee...@gmail.com > Subject: Re: [PATCH v6 1/4] acpi: arm64: add iort support for PMCG > [...] > > +/* > > + * PMCG model identifiers for use in smmu pmu driver. Please note > > + * that, this is not part of the IORT specification. > > And it is a Linux internal tag that has nothing to do with HW, it is just > fabricated > for matching a driver, I would like to have this clarified in the comment > please. > > I would have avoided adding another hook to differentiate platform data but > given that it is self-contained in IORT code that should be fine for the sake > of > making progress: > > Acked-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Thanks. I will wait for review of main driver patches and then will sent out a revised one incorporating your comments on this. Thanks, Shameer > > + */ > > +#define IORT_SMMU_V3_PMCG_GENERIC 0x00000000 /* Generic > SMMUv3 PMCG */ > > + > > int iort_register_domain_token(int trans_id, phys_addr_t base, > > struct fwnode_handle *fw_node); void > > iort_deregister_domain_token(int trans_id); > > -- > > 2.7.4 > > > >
