On 20/02/19 4:14 AM, Gregory CLEMENT wrote: > Hi Chris, > > On lun., févr. 18 2019, Chris Packham <[email protected]> > wrote: > >> Kirkwood has always had the ability to retrieve the local-mac-address >> from the hardware (usually this was configured by the bootloader). This >> is particularly useful when dealing with a legacy non-DT aware >> bootloader. >> >> The "error" message just indicated that the board used an old bootloader >> and in many cases users can't do anything about this. The message >> probably should have been pr_info() to inform the user that the kernel >> has been helpful but rather than than let's remove it entirely to make >> the kernel less noisy. >> >> Signed-off-by: Chris Packham <[email protected]> > > I'm OK with this patch, however as it is not a fix, it's too late for > 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released. >
No problem with that. We have a local fork I'll cherry pick it into once it hits linux-mvebu. > Thanks, > > gregory > >> --- >> arch/arm/mach-mvebu/kirkwood.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c >> index 0aa88105d46e..bf3ff0f580c2 100644 >> --- a/arch/arm/mach-mvebu/kirkwood.c >> +++ b/arch/arm/mach-mvebu/kirkwood.c >> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void) >> clk_prepare_enable(clk); >> >> /* store MAC address register contents in local-mac-address */ >> - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np); >> - >> pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL); >> if (!pmac) >> goto eth_fixup_no_mem; >> -- >> 2.20.1 >> >
