On 20/02/2019 15:09, Nikolay Aleksandrov wrote: > On 20/02/2019 14:48, Sebastian Gottschall wrote: >> *reminder* >> > [snip] >>>>>> } >>>>>> static void br_ip4_multicast_query(struct net_bridge *br, >>>> Is this also a problem in 4.20? This patch went into 4.20-rc1, so it >>>> has been around for a while with no reported issues that I can find. >>>> Any pointers to the reports? >>> >>> i need to check this. i found this patch in 4.9, 4.14 and 4.4 >>> the rest was picked up from the mailinglist. according to the git sources >>> of 4.20 and 5.0 the same code is in there as well >>> >>> i just got the report from users today and was able to reproduce it with >>> iptv streams. just by disabling the code it was working again. >>> >>> Sebastian >>>> >>>> thanks, >>>> >>>> greg k-h >>>> >>> > > Could you please include more details about the setup that's broken ? > Note that we were warned[1] of potential breakage from this change > after it went in and regardless of the suggestion from the RFC we'll > probably have to revert this patch. > > Ying Xu as author of the patch, any thoughts ? >
My bad, it's Hangbin Liu's patch. It was reported by Ying Xu. > Also adding Linus Lüssing to the CC as he was the one who warned against it. > Note that the warning was sent as a reply to my breakage fix, but it was > intended > for the original patch. > > Thanks, > Nik > > [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg272944.html >
