On Tue, Feb 26, 2019 at 12:01:14PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/watchdog/sc520_wdt.c: In function ‘fop_ioctl’: > drivers/watchdog/sc520_wdt.c:326:3: warning: this statement may fall through > [-Wimplicit-fallthrough=] > wdt_keepalive(); > ^~~~~~~~~~~~~~~ > drivers/watchdog/sc520_wdt.c:329:2: note: here > case WDIOC_GETTIMEOUT: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchdog/sc520_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c > index 6aadb56e7faa..403542f9ed8d 100644 > --- a/drivers/watchdog/sc520_wdt.c > +++ b/drivers/watchdog/sc520_wdt.c > @@ -324,8 +324,8 @@ static long fop_ioctl(struct file *file, unsigned int > cmd, unsigned long arg) > return -EINVAL; > > wdt_keepalive(); > - /* Fall through */ > } > + /* Fall through */ > case WDIOC_GETTIMEOUT: > return put_user(timeout, p); > default: > -- > 2.20.1 >
