Re: [PATCH net-next v2 7/8] net: switchdev: Replace port attr set SDO with a notification

[Ido Schimmel]

On Tue, Feb 26, 2019 at 05:14:26PM -0800, Florian Fainelli wrote:
> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> index af57c4a2b78a..b7988d49d708 100644
> --- a/net/bridge/br_switchdev.c
> +++ b/net/bridge/br_switchdev.c
> @@ -67,12 +67,17 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p,
>               .id = SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS,
>               .u.brport_flags = mask,
>       };
> +     struct switchdev_notifier_port_attr_info info = {
> +             .attr = &attr,
> +     };
>       int err;
>  
>       if (mask & ~BR_PORT_FLAGS_HW_OFFLOAD)
>               return 0;
>  
> -     err = switchdev_port_attr_set(p->dev, &attr);
> +     /* We run from atomic context here */
> +     err = call_switchdev_notifiers(SWITCHDEV_PORT_ATTR_SET, p->dev,
> +                                    &info.info, NULL);
>       if (err == -EOPNOTSUPP)

Florian, this needs to use notifier_to_errno() and check for any error.
With the ops, `-EOPNOTSUPP` was returned for devices that did not
implement `switchdev_ops`. Now they will simply not listen / reply to
the notification.

>               return 0;