On Fri, Mar 1, 2019 at 7:08 AM Alexey Dobriyan <adobri...@gmail.com> wrote:
>
> On Thu, Feb 28, 2019 at 09:41:09AM -0800, a...@linux-foundation.org wrote:
> > ---
> > a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned
> > +++ a/include/linux/types.h
> > @@ -155,9 +155,9 @@ typedef u64 dma_addr_t;
> > typedef u32 dma_addr_t;
> > #endif
> >
> > -typedef unsigned __bitwise gfp_t;
> > -typedef unsigned __bitwise slab_flags_t;
> > -typedef unsigned __bitwise fmode_t;
> > +typedef unsigned int __bitwise gfp_t;
> > +typedef unsigned int __bitwise slab_flags_t;
> > +typedef unsigned int __bitwise fmode_t;
>
> I don't know if this is desireable. Switching to "unsigned" is better:
> 1 less token and less 80 column pressure.
See the following commit.
commit a1ce18e4f941d2039aa3bdeee17db968919eac2f
Author: Joe Perches <j...@perches.com>
Date: Tue Mar 15 14:58:03 2016 -0700
checkpatch: warn on bare unsigned or signed declarations without int
Kernel style prefers "unsigned int <foo>" over "unsigned <foo>" and
"signed int <foo>" over "signed <foo>".
Emit a warning for these simple signed/unsigned <foo> declarations. Fix
it too if desired.
Signed-off-by: Joe Perches <j...@perches.com>
Acked-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
--
Best Regards
Masahiro Yamada
