On Fri, Mar 01, 2019 at 09:13:27AM +0900, Masahiro Yamada wrote: > On Fri, Mar 1, 2019 at 7:08 AM Alexey Dobriyan <adobri...@gmail.com> wrote: > > > > On Thu, Feb 28, 2019 at 09:41:09AM -0800, a...@linux-foundation.org wrote: > > > --- > > > a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned > > > +++ a/include/linux/types.h > > > @@ -155,9 +155,9 @@ typedef u64 dma_addr_t; > > > typedef u32 dma_addr_t; > > > #endif > > > > > > -typedef unsigned __bitwise gfp_t; > > > -typedef unsigned __bitwise slab_flags_t; > > > -typedef unsigned __bitwise fmode_t; > > > +typedef unsigned int __bitwise gfp_t; > > > +typedef unsigned int __bitwise slab_flags_t; > > > +typedef unsigned int __bitwise fmode_t; > > > > I don't know if this is desireable. Switching to "unsigned" is better: > > 1 less token and less 80 column pressure. > > > > See the following commit.
Ah, checkpatch.pl, how could we live without it.
