Hi RaviChandra, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.0] [cannot apply to next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/RaviChandra-Sadineni/cros_ec-Expose-sysfile-to-force-battery-cut-off-on-shutdown/20190304-220513 config: x86_64-randconfig-x017-201909 (attached as .config) compiler: gcc-8 (Debian 8.2.0-21) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/platform/chrome/cros_ec_sysfs.c:369:3: error: >> 'dev_attr_cutoff_battery_at_shutdown' undeclared here (not in a function); >> did you mean 'dev_attr_cutoff_at_shutdown'? &dev_attr_cutoff_battery_at_shutdown.attr, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dev_attr_cutoff_at_shutdown In file included from drivers/platform/chrome/cros_ec_sysfs.c:24: include/linux/device.h:602:26: warning: 'dev_attr_cutoff_at_shutdown' defined but not used [-Wunused-variable] struct device_attribute dev_attr_##_name = __ATTR_WO(_name) ^~~~~~~~~ drivers/platform/chrome/cros_ec_sysfs.c:366:8: note: in expansion of macro 'DEVICE_ATTR_WO' static DEVICE_ATTR_WO(cutoff_at_shutdown); ^~~~~~~~~~~~~~ vim +369 drivers/platform/chrome/cros_ec_sysfs.c 367 368 static struct attribute *__ec_attrs[] = { > 369 &dev_attr_cutoff_battery_at_shutdown.attr, 370 &dev_attr_kb_wake_angle.attr, 371 &dev_attr_reboot.attr, 372 &dev_attr_version.attr, 373 &dev_attr_flashinfo.attr, 374 NULL, 375 }; 376 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
