On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada <[email protected]> wrote: > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > <[email protected]> wrote: > > > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. An > > improvement in this case is that banks that are not masked will now be > > skipped.
> Please do not do this. > > Nothing in this driver says the GPIO width is 8-bit. Huh? https://elixir.bootlin.com/linux/latest/source/include/dt-bindings/gpio/uniphier-gpio.h#L9 Isn't a hardcoding? -- With Best Regards, Andy Shevchenko
